Skip to content

Allow PublishReadyToRunEmitSymbols to be overridden #121406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow PublishReadyToRunEmitSymbols to be overridden #121406

wants to merge 3 commits into from

Conversation

@kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Nov 6, 2025

Description

This PR updates PublishReadyToRunEmitSymbols to allow it to be overridden. It aligns the behavior with the SDK mirror.

@kotlarmilos kotlarmilos self-assigned this Nov 6, 2025
@kotlarmilos kotlarmilos added the os-ios Apple iOS label Nov 6, 2025
@kotlarmilos kotlarmilos added this to the 11.0.0 milestone Nov 6, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Nov 6, 2025

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the PublishReadyToRunEmitSymbols property initialization to respect user-provided values. Previously, the property was unconditionally set to false for Apple platforms (iOS, tvOS, macOS Catalyst), which prevented users from overriding this behavior.

Key Changes:

  • Modified the condition for PublishReadyToRunEmitSymbols to only set it to false when the property hasn't been explicitly set by the user

@kotlarmilos
Copy link
Member Author

kotlarmilos commented Nov 6, 2025

/azp run runtime-ioslike

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 6, 2025

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Nov 6, 2025
Open
Open
Open
Open
@jkoritzinsky jkoritzinsky mentioned this pull request Nov 6, 2025
Open
akoeplinger
akoeplinger reviewed Nov 6, 2025
View reviewed changes
@kotlarmilos
Copy link
Member Author

kotlarmilos commented Nov 7, 2025 •
edited
Loading

I think arcade overrides PublishReadyToRunEmitSymbols in https://github.com/dotnet/arcade/blob/7d717a49d570577936361c14de38bf61271aa274/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L10

iOS build is failing with the System.NotImplementedException: iOS

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Nov 7, 2025

We can change arcade to not forcibly override it.

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Nov 7, 2025

Arcade PR here: dotnet/arcade#16281

This was referenced Nov 13, 2025
Open
Open
Open
@build-analysis build-analysis bot mentioned this pull request Nov 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger left review comments

Copilot code review Copilot Copilot left review comments

@steveisok steveisok steveisok approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@kotlarmilos kotlarmilos

Labels

area-crossgen2-coreclr os-ios Apple iOS

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@kotlarmilos @jkoritzinsky @steveisok @akoeplinger